INTEGRATION [PR#1399 > development/8.1] bugfix: S3C-4275 enable skip-scan for DelimiterVersions with a delimiter #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase coverage for DelimiterVersions listing algorithm to have it in par with DelimiterMaster before attempting a fix: most existing tests from DelimiterMaster have been copied and adapted to fit the DelimiterVersions logic.
Enable the skip-scan optimization to work for DelimiterVersions listing algorithm when used with a delimiter. For this to work, instead of returning FILTER_ACCEPT when encountering a version that matches the master key (which resets the skip-scan counter), return FILTER_SKIP to let the skip-scan counter increment and eventually skip the entire listed common prefix after 100 entries.
…' into tmp/octopus/w/7.10/bugfix/S3C-4275-versionListingWithDelimiterInefficiency
…iciency' into tmp/octopus/w/8.1/bugfix/S3C-4275-versionListingWithDelimiterInefficiency
Codecov Report
@@ Coverage Diff @@
## development/8.1 #1401 +/- ##
===================================================
+ Coverage 58.50% 58.55% +0.04%
===================================================
Files 181 181
Lines 11701 11701
===================================================
+ Hits 6846 6851 +5
+ Misses 4855 4850 -5
Continue to review full report at Codecov.
|
bert-e
deleted the
w/8.1/bugfix/S3C-4275-versionListingWithDelimiterInefficiency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #1399.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.1/bugfix/S3C-4275-versionListingWithDelimiterInefficiency, please follow thisprocedure:
$ git fetch $ git checkout w/8.1/bugfix/S3C-4275-versionListingWithDelimiterInefficiency $ # <amend or cancel the changeset by _adding_ new commits> $ git push origin w/8.1/bugfix/S3C-4275-versionListingWithDelimiterInefficiencyPlease always comment pull request #1399 instead of this one.