improvement: S3C-3044-add-audit-log-fields #1099
Conversation
Hello anurag4dsb,My role is to assist you with the merge of this Status report is not available. |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
Follow integration pull requests if you would like to be notified of |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include a mandatory approval from @jonathan-gramain. |
| @@ -24,6 +24,12 @@ function vaultSignatureCb(err, authInfo, log, callback, streamingV4Params) { | |||
| const info = authInfo.message.body; | |||
| const userInfo = new AuthInfo(info.userInfo); | |||
| const authorizationResults = info.authorizationResults; | |||
| const auditLog = { accountDisplayName: userInfo.getAccountDisplayName() }; | |||
| const iamDisplayName = userInfo.getIAMdisplayName(); | |||
| if (iamDisplayName) { | |||
There was a problem hiding this comment.
wondering if it would be beneficial to list the display name even if it is null, for logging purposes. Not sure how helpful that would be though.
There was a problem hiding this comment.
Good point! The requirement for the customer is only username, I added account name cuz I thought that was important. Adding user name as null will just extra add extra processing for the of leef log converter. We already log too much in info :)
So that’s why I didn’t add it .
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include a mandatory approval from @jonathan-gramain. The following options are set: approve |
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue S3C-3044. Goodbye anurag4dsb. |
This PR adds audit log fields for Cloudserver without adding an extra log line
Extra fields:
accountDisplayName: account name
iamDisplayName: username