INTEGRATION [PR#1031 > development/8.1] bugfix: S3C-2899 implement v1 format for DelimiterVersions listing #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New helper function to convert listing params from v0 to v1, when a listing of master keys is requested. This logic is shared between DelimiterMaster and MPU listing, hence a shared helper is useful. Also, update the test function performListing to prepare for v1 testing of listing algos, by adding the vFormat parameter. Also check that getMDParams() returns a valid object to enhance coverage.
Implement the v1 versioning key format for DelimiterVersions listing method, in addition to v0. Enhance existing unit tests to check the result of getMDParams()
…topus/w/7.7/bugfix/S3C-2899-vformatV1delimiterVersions
…tmp/octopus/w/8.1/bugfix/S3C-2899-vformatV1delimiterVersions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #1031.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.1/bugfix/S3C-2899-vformatV1delimiterVersions, please follow thisprocedure:
$ git fetch $ git checkout w/8.1/bugfix/S3C-2899-vformatV1delimiterVersions $ # <amend or cancel the changeset by _adding_ new commits> $ git push origin w/8.1/bugfix/S3C-2899-vformatV1delimiterVersionsPlease always comment pull request #1031 instead of this one.