-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: S3C-2899 pass vFormat to listing params #1016
bugfix: S3C-2899 pass vFormat to listing params #1016
Conversation
This to benefit from the longer line length allowed (80 -> 120)
Add an optional "vFormat" param to constructors of listing algo classes, to specify the versioning key format used by the bucket to list. Currently only v0 is supported. Code cleanups done in the listing classes to prepare support for the v1 format.
Hello jonathan-gramain,My role is to assist you with the merge of this Status report is not available. |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.1/bugfix/S3C-2899-passVformatToListingParams origin/development/8.1
$ git merge origin/w/7.7/bugfix/S3C-2899-passVformatToListingParams
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.1/bugfix/S3C-2899-passVformatToListingParams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@bert-e approve |
// non-PHD master version or a version whose master is a PHD version | ||
this.prvKey = undefined; | ||
this.prvPHDKey = undefined; | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This JSDoc was not meant to be removed, I will re-introduce it in the next PR.
bert-e? |
bert-eeeee |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
Follow integration pull requests if you would like to be notified of The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue S3C-2899. Goodbye jonathan-gramain. |
Add an optional "vFormat" param to constructors of listing algo
classes, to specify the versioning key format used by the bucket to
list. Currently only v0 is supported.
Code cleanups done in the listing classes to prepare support for the
v1 format.