Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility jasync-sql 2.1.9+ #381

Closed
KevinAtSesam opened this issue Jan 18, 2023 · 4 comments
Closed

Compatibility jasync-sql 2.1.9+ #381

KevinAtSesam opened this issue Jan 18, 2023 · 4 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@KevinAtSesam
Copy link

With the later updates of jasync-sql, there was a bug that could be triggered by changing the settings using scalikejdbc-async 0.16.0. I made an issue related to this, but it also means that you'll have to look at the changes to keep your project compatible:

jasync-sql/jasync-sql#359

@oshai
Copy link

oshai commented Jan 18, 2023

As a workaround the issue (or more accurate to avoid it in the future) I suggest to replace Configuration.copy() call with Configuration.copyConfiguration().
I created a PR here: jasync-sql/jasync-sql#362 and would like to know if that something that seems reasonable to change here.
I also opened a suggestion to change that in kotlin language here: https://youtrack.jetbrains.com/issue/KT-56022/Support-JvmOverload-for-data-class-copy-function

@seratch seratch added the dependencies Pull requests that update a dependency file label Jan 20, 2023
@oshai
Copy link

oshai commented Jan 29, 2023

Looks like the issue with copy is in the class JasyncConfiguration.scala.
I created a PR that might fix it here: jasync-sql/jasync-sql#377

Regardless, publishing a version of scalikejdbc with latest jasync will solve it.

@oshai
Copy link

oshai commented Jan 30, 2023

@seratch are there any plans to release a new version? it should solve the issue.

@seratch
Copy link
Member

seratch commented Apr 17, 2023

Sorry for my slow response here, I just released a new version: https://github.com/scalikejdbc/scalikejdbc-async/releases/tag/0.18.0

@seratch seratch closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

No branches or pull requests

3 participants