Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better key casing transform behavior to the AMS monkey patch #20

Open
carsomyr opened this issue Jun 30, 2021 · 0 comments
Open

Add better key casing transform behavior to the AMS monkey patch #20

carsomyr opened this issue Jun 30, 2021 · 0 comments

Comments

@carsomyr
Copy link
Member

carsomyr commented Jun 30, 2021 •
edited
Loading

Currently AMS is dasherizing the keys of JSON objects embedded as JSON:API attributes. This alters the meaning of such embedded documents, and the JSON:API specification doesn't seem to permit key alteration. Perhaps it's time to integrate the changes proposed in rails-api/active_model_serializers#1834 into the monkey patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carsomyr