Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for managing ip reverse attribute #48

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Conversation

nicolai86
Copy link
Contributor

@nicolai86 nicolai86 commented Mar 15, 2018

This PR adds support to manage scaleway_ips reverse attribute.
The change includes an update to the github.com/nicolai86/scaleway-sdk dependency, as well as document and test updates.

The changed resource looks like this:

resource "scaleway_ip" "test" {
  reverse = "www.google.com"
}

Once merged, closes #34

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nicolai86 nicolai86 merged commit 2d9b42d into master Mar 15, 2018
@nicolai86 nicolai86 deleted the reverse-ip branch March 15, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: handle reverse dns entry for scaleway IPs
2 participants