Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(instance): fix SG on external rules plan #446

Merged
merged 2 commits into from
Apr 6, 2020
Merged

fix(instance): fix SG on external rules plan #446

merged 2 commits into from
Apr 6, 2020

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Apr 5, 2020

Fixes #445

Signed-off-by: Patrik Cyvoct [email protected]

@ghost ghost added the size/XS label Apr 5, 2020
@Sh4d1 Sh4d1 mentioned this pull request Apr 5, 2020
Closed
@Sh4d1
fix review
95a2282 
Signed-off-by: Patrik Cyvoct <[email protected]>
kindermoumoute
kindermoumoute approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kindermoumoute kindermoumoute merged commit 513cddf into scaleway:master Apr 6, 2020
@mbenabda mbenabda mentioned this pull request May 27, 2020
Closed
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of scaleway_instance_security_group_rules triggers constant terraform change.
3 participants
@Sh4d1 @kindermoumoute @remyleone