Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(baremetal): add offer data source #361

Merged
merged 8 commits into from
Dec 6, 2019
Merged

feat(baremetal): add offer data source #361

merged 8 commits into from
Dec 6, 2019

Conversation

kindermoumoute
Copy link
Contributor

No description provided.

@kindermoumoute kindermoumoute changed the title Data source baremetal offer feat(baremetal): add offer data source Dec 5, 2019
@kindermoumoute kindermoumoute force-pushed the data-source-baremetal-offer branch from d33c42a to e1d2576 Compare December 5, 2019 15:50
jerome-quere
jerome-quere suggested changes Dec 5, 2019
View reviewed changes
scaleway/data_source_baremetal_offer_beta.go Outdated Show resolved Hide resolved
scaleway/data_source_baremetal_offer_beta.go Outdated Show resolved Hide resolved
scaleway/data_source_baremetal_offer_beta.go Outdated Show resolved Hide resolved
scaleway/data_source_baremetal_offer_beta.go Outdated Show resolved Hide resolved
@ghost ghost added documentation size/XL and removed size/XXL labels Dec 6, 2019
QuentinBrosse
QuentinBrosse suggested changes Dec 6, 2019
View reviewed changes
scaleway/data_source_baremetal_offer_beta.go Outdated Show resolved Hide resolved
scaleway/data_source_baremetal_offer_beta.go Outdated Show resolved Hide resolved
scaleway/helpers_baremetal.go Outdated Show resolved Hide resolved
scaleway/helpers_baremetal.go Outdated Show resolved Hide resolved
scaleway/provider.go Show resolved Hide resolved
website/docs/d/baremetal_offer_beta.html.markdown Outdated Show resolved Hide resolved
website/docs/d/baremetal_offer_beta.html.markdown Show resolved Hide resolved
QuentinBrosse
QuentinBrosse approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jerome-quere
jerome-quere approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kindermoumoute kindermoumoute merged commit 601efeb into scaleway:master Dec 6, 2019
@kindermoumoute kindermoumoute deleted the data-source-baremetal-offer branch December 6, 2019 14:34
@remyleone remyleone added the elastic-metal Elastic-metal issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBrosse QuentinBrosse QuentinBrosse approved these changes

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
dependencies documentation elastic-metal Elastic-metal issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kindermoumoute @jerome-quere @QuentinBrosse @remyleone