Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): data source image #359

Merged
merged 9 commits into from
Dec 5, 2019
Merged

Conversation

kindermoumoute
Copy link
Contributor

No description provided.

@ghost ghost added the size/L label Dec 4, 2019
scaleway/data_source_instance_image.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_image.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_image.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_image.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_image.go Show resolved Hide resolved
@kindermoumoute kindermoumoute force-pushed the data-source-instance-image branch from 1f12844 to a91cb48 Compare December 4, 2019 16:15
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost added documentation size/XL and removed size/L labels Dec 4, 2019
scaleway/data_source_instance_image.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_image.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_image.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_image.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_image.go Outdated Show resolved Hide resolved
website/docs/d/instance_image.html.markdown Outdated Show resolved Hide resolved
website/scaleway.erb Show resolved Hide resolved
scaleway/data_source_instance_image.go Show resolved Hide resolved
scaleway/data_source_instance_image.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_image.go Outdated Show resolved Hide resolved
@kindermoumoute kindermoumoute changed the title feat: data source instance image feat(instance): data source image Dec 5, 2019
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kindermoumoute kindermoumoute merged commit f69dec3 into master Dec 5, 2019
@kindermoumoute kindermoumoute deleted the data-source-instance-image branch December 5, 2019 13:01
@@ -7,6 +7,9 @@ description: |-

# scaleway_image

**DEPRECATED**: This resource is deprecated and will be removed in `v2.0+`.
Please use `scaleway_instance_image` instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or scaleway_marketplace_image depending on your usage


# scaleway_instance_image

Gets information about an instance image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are looking for public image like oses, and ready-to-use application please have a look at scaleway_marketplace_image datasource instead

```hcl
// Get info by image name
data "scaleway_instance_image" "my_image" {
name = "ubuntu bionic"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't feature a use-case like ubuntu. These use-case should be cover by scaleway_marketplace_image
Use a name like my-image-name

@jerome-quere
Copy link
Contributor

close #276

@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants