Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: feat(instance): data source volume #356

Merged
merged 8 commits into from
Dec 5, 2019
Merged

wip: feat(instance): data source volume #356

merged 8 commits into from
Dec 5, 2019

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone self-assigned this Dec 4, 2019
kindermoumoute
kindermoumoute requested changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be a new data source. data_source_volume.go must remain and new data source should live in data_source_instance_volume.go

@ghost ghost added size/XL and removed size/L labels Dec 5, 2019
@QuentinBrosse QuentinBrosse changed the title wip: feat: data source instance volume wip: feat(instance): data source volume Dec 5, 2019
@remyleone remyleone force-pushed the data-source-instance-volume branch from 7a757e9 to 3e286a1 Compare December 5, 2019 09:44
@ghost ghost added size/L and removed size/XL labels Dec 5, 2019
QuentinBrosse
QuentinBrosse suggested changes Dec 5, 2019
View reviewed changes
website/scaleway.erb Outdated Show resolved Hide resolved
website/scaleway.erb Outdated Show resolved Hide resolved
scaleway/data_source_instance_volume.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_volume.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_volume.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_volume.go Outdated Show resolved Hide resolved
website/docs/d/instance_volume.html.markdown Outdated Show resolved Hide resolved
website/docs/d/instance_volume.html.markdown Outdated Show resolved Hide resolved
website/docs/d/instance_volume.html.markdown Outdated Show resolved Hide resolved
website/docs/d/instance_volume.html.markdown Outdated Show resolved Hide resolved
kindermoumoute
kindermoumoute requested changes Dec 5, 2019
View reviewed changes
scaleway/data_source_instance_volume.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_volume.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_volume_test.go Show resolved Hide resolved
scaleway/data_source_instance_volume_test.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_volume_test.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_volume_test.go Outdated Show resolved Hide resolved
scaleway/data_source_instance_volume_test.go Show resolved Hide resolved
@QuentinBrosse QuentinBrosse mentioned this pull request Dec 5, 2019
Closed
kindermoumoute
kindermoumoute approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

QuentinBrosse
QuentinBrosse approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone force-pushed the data-source-instance-volume branch from 0ae7f48 to b128861 Compare December 5, 2019 13:17
@remyleone remyleone merged commit 0940f17 into master Dec 5, 2019
@remyleone remyleone deleted the data-source-instance-volume branch November 19, 2020 09:49
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBrosse QuentinBrosse QuentinBrosse approved these changes

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees

@remyleone remyleone

Labels
documentation instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remyleone @kindermoumoute @QuentinBrosse