Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(baremetal): support server offer name #345

Merged
merged 3 commits into from
Dec 2, 2019
Merged

feat(baremetal): support server offer name #345

merged 3 commits into from
Dec 2, 2019

Conversation

QuentinBrosse
Copy link
Contributor

No description provided.

@QuentinBrosse QuentinBrosse marked this pull request as ready for review November 29, 2019 16:51
kindermoumoute
kindermoumoute requested changes Nov 29, 2019
View reviewed changes
scaleway/helpers_test.go Outdated Show resolved Hide resolved
scaleway/helpers_test.go Outdated Show resolved Hide resolved
scaleway/helpers_test.go Outdated Show resolved Hide resolved
kindermoumoute
kindermoumoute approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jerome-quere
jerome-quere approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit 2fbb44b into scaleway:master Dec 2, 2019
@QuentinBrosse QuentinBrosse deleted the baremetal/offer-name branch March 5, 2020 16:10
@remyleone remyleone added the elastic-metal Elastic-metal issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
dependencies documentation elastic-metal Elastic-metal issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuentinBrosse @jerome-quere @kindermoumoute @remyleone