Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instance): create new resource instance_ip_reverse_dns #315

Merged
merged 4 commits into from
Nov 13, 2019
Merged

feat(instance): create new resource instance_ip_reverse_dns #315

merged 4 commits into from
Nov 13, 2019

Conversation

jerome-quere
Copy link
Contributor

@jerome-quere jerome-quere commented Nov 12, 2019 •
edited
Loading

fix #314

QuentinBrosse
QuentinBrosse approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

website/docs/r/instance_ip_reverse_dns.html.markdown Outdated Show resolved Hide resolved
kindermoumoute
kindermoumoute approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere jerome-quere merged commit 2d91e15 into scaleway:master Nov 13, 2019
@jerome-quere jerome-quere deleted the reverse branch November 19, 2019 10:33
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBrosse QuentinBrosse QuentinBrosse approved these changes

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
documentation instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create instance and add reverse dns in one run?
4 participants
@jerome-quere @kindermoumoute @QuentinBrosse @remyleone