Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instance): add ipv6 info on server resource #301

Merged
merged 3 commits into from
Oct 23, 2019
Merged

feat(instance): add ipv6 info on server resource #301

merged 3 commits into from
Oct 23, 2019

Conversation

jerome-quere
Copy link
Contributor

fix #275

@ghost ghost added the dependencies label Oct 23, 2019
kindermoumoute
kindermoumoute requested changes Oct 23, 2019
View reviewed changes
scaleway/helpers_test.go Outdated Show resolved Hide resolved
scaleway/helpers_test.go Show resolved Hide resolved
kindermoumoute
kindermoumoute approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere jerome-quere merged commit 315ee62 into scaleway:master Oct 23, 2019
@jerome-quere jerome-quere deleted the ipv6 branch November 19, 2019 10:33
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
dependencies documentation instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

instance_server: Expose a public_ipv6 attribute
3 participants
@jerome-quere @kindermoumoute @remyleone