Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(security_group): add ANY protocol #297

Merged
merged 6 commits into from
Oct 23, 2019
Merged

fix(security_group): add ANY protocol #297

merged 6 commits into from
Oct 23, 2019

Conversation

kindermoumoute
Copy link
Contributor

No description provided.

jerome-quere
jerome-quere suggested changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a good idea to use ANY by default in security group rule

@kindermoumoute kindermoumoute changed the title fix(security_group): switch protocol default value to ANY fix(security_group): add ANY protocol Oct 22, 2019
@kindermoumoute
Copy link
Contributor Author

@jerome-quere yes, I fixed it in latest commit but forgot to update the name ^^

QuentinBrosse
QuentinBrosse approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jerome-quere
jerome-quere approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kindermoumoute kindermoumoute merged commit db6c248 into scaleway:master Oct 23, 2019
@kindermoumoute kindermoumoute deleted the security-group-any branch October 23, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicbourgois loicbourgois loicbourgois approved these changes

@QuentinBrosse QuentinBrosse QuentinBrosse approved these changes

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
dependencies documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kindermoumoute @jerome-quere @QuentinBrosse @loicbourgois