Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break: rename disable_public_ip to disable_dynamic_ip #293

Merged
merged 2 commits into from
Oct 18, 2019
Merged

break: rename disable_public_ip to disable_dynamic_ip #293

merged 2 commits into from
Oct 18, 2019

Conversation

QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented Oct 18, 2019 •
edited
Loading

This PR is a BREAKING CHANGE and:

  • Remove the misnamed attribute disable_public_ip (with a "Please use disable_dynamic_ip instead" message)
  • Replace it with a disable_dynamic_ip attribute
  • Document the disable_dynamic_ip attribute

kindermoumoute
kindermoumoute approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit 5a29350 into scaleway:master Oct 18, 2019
@QuentinBrosse QuentinBrosse deleted the instance/fix-dynamic-ip branch March 5, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuentinBrosse @kindermoumoute