feat(lb): add lb beta resource #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
kindermoumoute
requested changes
Oct 17, 2019
scaleway/helpers_test.go
Outdated
| @@ -192,3 +195,40 @@ func TestGetRandomName(t *testing.T) { | |||
| name := getRandomName("test") | |||
| assert.True(t, strings.HasPrefix(name, "tf-test-")) | |||
| } | |||
|
|
|||
| var IPv4Regexp = regexp.MustCompile("([0-9]{1,3}.){3}[0-9]{1,3}") | |||
There was a problem hiding this comment.
Use net.ParseIP() ==> https://play.golang.org/p/QkKbbJSrOCT
scaleway/helpers_test.go
Outdated
| } | ||
|
|
||
| func testCheckResourceAttrUUID(name string, key string) resource.TestCheckFunc { | ||
| return testCheckResourceAttrRegex(name, key, UUIDRegex) |
There was a problem hiding this comment.
scaleway/resource_lb_lb_beta.go
Outdated
| Optional: true, | ||
| Description: "Array of tags to associate with the load-balancer", | ||
| }, | ||
| "ips": { |
There was a problem hiding this comment.
how do we add an IP?
There was a problem hiding this comment.
IP is computed for now when the will allow IP previsioning before we will have a instance style attach/detach paradigm. As this will break soon i remove list for now
scaleway/resource_lb_lb_beta.go
Outdated
|
|
||
| func resourceScalewayLbLbBeta() *schema.Resource { | ||
| return &schema.Resource{ | ||
| Create: resourceScalewayLbLbBetaCreate, |
There was a problem hiding this comment.
Duplicate LbLb in the name (same for Read, Update and Delete)
QuentinBrosse
suggested changes
Oct 17, 2019
scaleway/resource_lb_lb_beta.go
Outdated
| }, | ||
| SchemaVersion: 0, | ||
| Timeouts: &schema.ResourceTimeout{ | ||
| Create: &BaremetalServerResourceTimeout, |
scaleway/resource_lb_lb_beta.go
Outdated
| } | ||
|
|
||
| if d.HasChange("name") || d.HasChange("tags") { | ||
|
|
scaleway/resource_lb_lb_beta.go
Outdated
| err = lbAPI.DeleteLb(&lb.DeleteLbRequest{ | ||
| Region: region, | ||
| LbID: ID, | ||
| // This parameter will probably be breaking change when ip pre reservation will exist. |
QuentinBrosse
approved these changes
Oct 17, 2019
scaleway/resource_lb_beta.go
Outdated
| }, | ||
| "ip_id": { | ||
| Type: schema.TypeString, | ||
| Computed: true, |
scaleway/resource_lb_beta.go
Outdated
| }, | ||
| "ip_address": { | ||
| Type: schema.TypeString, | ||
| Computed: true, |
kindermoumoute
approved these changes
Oct 17, 2019
kindermoumoute
approved these changes
Oct 17, 2019
|
Linked to #294 |
remyleone
added
the
load-balancer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.