Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): do not update autoscaled pool size #265

Merged
merged 4 commits into from
Oct 10, 2019

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Oct 10, 2019

Signed-off-by: Patrik Cyvoct [email protected]

@ghost ghost added the size/XS label Oct 10, 2019
scaleway/resource_k8s_pool_beta.go Outdated Show resolved Hide resolved
Signed-off-by: Patrik Cyvoct <[email protected]>
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse
Copy link
Contributor

@Sh4d1 This branch has conflicts that must be resolved :/

@Sh4d1
Copy link
Contributor Author

Sh4d1 commented Oct 10, 2019

Resolved!

Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1
Copy link
Contributor Author

Sh4d1 commented Oct 10, 2019

@QuentinBrosse tests fixed

@QuentinBrosse QuentinBrosse merged commit 2bd47a4 into scaleway:master Oct 10, 2019
@Sh4d1 Sh4d1 deleted the k8s_autoscaling branch October 10, 2019 12:31
@remyleone remyleone added the k8s Kubernetes Kapsule issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants