feat(k8s): wait for pool to be ready and add 'nodes' in its output #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Sh4d1
suggested changes
Feb 7, 2020
There was a problem hiding this comment.
Waiting on how the sdk PR goes to finish the review but a few things:
- waiting on the node ready on the read doesn't seems like a good idea (for instance if a node has crashed, and autohealing is off, the read will fail). Maybe just add it on create/upgrade
- add the name of the node :)
|
I added node name and pool ID in the output. |
|
I also moved the waiting for nodes in create/update only. Otherwise it leads to unpredictable behaviour as you mentioned. |
debovema
force-pushed
the
pool-nodes
branch
3 times, most recently
from
4e49d4e to
dd12f2b
Compare
Sh4d1
suggested changes
Feb 18, 2020
There was a problem hiding this comment.
It would be nice to add the wait_for_pool_ready on the pool as well.
Also could you add some tests to check that the behaviour is ok:
- just wait on the pools ready, and check that the status of the nodes is running and the number is correct
- also modify the documentation to reflect the changes
debovema
changed the title
debovema
force-pushed
the
pool-nodes
branch
2 times, most recently
from
0606f8f to
49c55a4
Compare
debovema
force-pushed
the
pool-nodes
branch
4 times, most recently
from
fb3593d to
c9ee2a6
Compare
|
LGTM |
loicbourgois
suggested changes
Feb 19, 2020
debovema
force-pushed
the
pool-nodes
branch
4 times, most recently
from
6419b53 to
b2b95d5
Compare
kindermoumoute
requested changes
Feb 20, 2020
|
Thanks @Sh4d1 @loicbourgois @kindermoumoute ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on scaleway/scaleway-sdk-go#312To test with the scaleway-sdk-go patch from scaleway/scaleway-sdk-go#312,run:
=> scaleway/scaleway-sdk-go#312 was merged