Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add scaleway_instance_security_group_rules resource #391

Merged
merged 25 commits into from
Feb 10, 2020
Merged

feat: add scaleway_instance_security_group_rules resource #391

merged 25 commits into from
Feb 10, 2020

Conversation

loicbourgois
Copy link
Contributor

@loicbourgois loicbourgois commented Jan 29, 2020 •
edited
Loading

Fixes #381

@ghost ghost added size/L and removed size/L labels Jan 29, 2020
kindermoumoute
kindermoumoute requested changes Feb 3, 2020
View reviewed changes
scaleway/helpers.go Show resolved Hide resolved
scaleway/helpers_instance.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group.go Show resolved Hide resolved
scaleway/resource_instance_security_group.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group_rules.go Outdated Show resolved Hide resolved
jerome-quere
jerome-quere suggested changes Feb 4, 2020
View reviewed changes
scaleway/resource_instance_security_group.go Show resolved Hide resolved
scaleway/resource_instance_security_group_rules.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group_rules.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group_rules.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group_rules.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group_rules_test.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group_rules_test.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group.go Show resolved Hide resolved
scaleway/resource_instance_security_group_rules_test.go Outdated Show resolved Hide resolved
scaleway/resource_instance_security_group_rules_test.go Outdated Show resolved Hide resolved
kindermoumoute
kindermoumoute approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

QuentinBrosse
QuentinBrosse approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jerome-quere
jerome-quere suggested changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need documentation

@ghost ghost added the documentation label Feb 7, 2020
jerome-quere
jerome-quere approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere jerome-quere merged commit 7e19dcc into scaleway:master Feb 10, 2020
@QuentinBrosse QuentinBrosse mentioned this pull request Mar 25, 2020
Closed
17 tasks
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBrosse QuentinBrosse QuentinBrosse approved these changes

@kindermoumoute kindermoumoute kindermoumoute approved these changes

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
documentation instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't remove SecurityGroup Rule flexibilty for v2
5 participants
@loicbourgois @jerome-quere @kindermoumoute @QuentinBrosse @remyleone