Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(k8s): version is required #389

Merged
merged 1 commit into from
Jan 23, 2020
Merged

fix(k8s): version is required #389

merged 1 commit into from
Jan 23, 2020

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Jan 19, 2020

Signed-off-by: Patrik Cyvoct [email protected]

@Sh4d1
fix(k8s): version is required
a4f911c 
Signed-off-by: Patrik Cyvoct <[email protected]>
jerome-quere
jerome-quere approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere
Copy link
Contributor

@Sh4d1 did tests need to be updated?

@Sh4d1
Copy link
Contributor Author

Sh4d1 commented Jan 20, 2020

@jerome-quere nope, it wasnt working anyway 😅

@jerome-quere jerome-quere merged commit 430cdef into scaleway:master Jan 23, 2020
@remyleone remyleone added the k8s Kubernetes Kapsule issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
documentation k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sh4d1 @jerome-quere @remyleone