feat(lb): add support for frontend ACL #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hi @alekc Thank you very much for your contribution 👍 . In the instance product we do something like this: For ACL this would translate to This notation as multiple advantages:
Do you want to work on this on this PR or do you prefer we merge it as is. Knowing that we will implement the above solution before the next release? |
|
Ok, I will amend the current pr to align it to security groups. |
alekc
commented
Jan 10, 2020
|
First draft for realignment. I need to write a better testing, but otherwise it's almost there I'd say (still need to build the provider and try to run some create/update/destroy by hand to). This is a full example resource scaleway_lb_frontend_beta frt01 {
lb_id = scaleway_lb_beta.lb01.id
backend_id = scaleway_lb_backend_beta.bkd01.id
name = "tf-test"
inbound_port = 80
timeout_client = "30s"
acl {
name = "test-acl"
action {
type = "allow"
}
match {
ip_subnet = ["192.168.0.1", "192.168.0.2", "192.168.10.0/24"]
http_filter = "acl_http_filter_none"
http_filter_value = ["criteria1","criteria2"]
invert = "true"
}
}
acl {
action {
type = "allow"
}
match {
http_filter = "path_begin"
http_filter_value = ["criteria1","criteria2"]
invert = "true"
}
}
acl {
action {
type = "allow"
}
match {
http_filter_value = ["criteria1","criteria2"]
}
}
acl {
action {
type = "allow"
}
match {
http_filter = "acl_http_filter_none"
http_filter_value = ["criteria1","criteria2"]
}
}
acl {
match {
ip_subnet = ["192.168.0.1", "192.168.0.2", "192.168.10.0/24"]
http_filter = "acl_http_filter_none"
http_filter_value = ["criteria1","criteria2"]
invert = "true"
}
action {
type = "deny"
}
}
}Some considerations:
acl {
action_type = "allow/deny"
}
|
jerome-quere
suggested changes
Jan 15, 2020
There was a problem hiding this comment.
Hey, great work 👏 . I added a few remarks.
@kindermoumoute can you please also have a look?
|
Thanks @jerome-quere , I will amend pull request. Meanwhile I am having some issues with update tests because I think there is a bug with scaleway api Notice the and from api documentation |
|
@kindermoumoute or @jerome-quere can you verify if there is indeed a bug with the scaleway api as described in https://github.com/terraform-providers/terraform-provider-scaleway/pull/382#issuecomment-575088706? I don't think there is a public place for those kinds of reports. |
|
The issue has been escalated to the load-balancer team, I'll let you know as soon as we have more information. |
|
@alekc @jerome-quere Fixed ! Sorry about that. |
jerome-quere
changed the title
|
👏 |
Closed
remyleone
added
the
load-balancer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for scaleway lb acl (https://developers.scaleway.com/en/products/lb/api/#get-ff2ff4)
I followed scaleway official api, so tf structure looks like this
potentially we can transform action.type in action_type, but it's probably best to keep it aligned to official apis.
Tests results