Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource server: improve IP attachment usability #14

Merged
merged 1 commit into from
Jul 20, 2017

Conversation

nicolai86
Copy link
Contributor

@nicolai86 nicolai86 commented Jul 19, 2017

this changeset ensures that if the IP attachment fails due to an invalid input, the creation server resource fails.
previously this was silently ignored, which led to #1.

make testacc TESTARGS="-run='TestAccScalewayServer'"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run='TestAccScalewayServer' -timeout 120m
?       github.com/terraform-providers/terraform-provider-scaleway    [no test files]
=== RUN   TestAccScalewayServer_importBasic
--- PASS: TestAccScalewayServer_importBasic (101.07s)
=== RUN   TestAccScalewayServer_Basic
--- PASS: TestAccScalewayServer_Basic (118.88s)
=== RUN   TestAccScalewayServer_ExistingIP
--- PASS: TestAccScalewayServer_ExistingIP (102.68s)
=== RUN   TestAccScalewayServer_Volumes
--- PASS: TestAccScalewayServer_Volumes (136.93s)
=== RUN   TestAccScalewayServer_SecurityGroup
--- PASS: TestAccScalewayServer_SecurityGroup (117.27s)
PASS
ok      github.com/terraform-providers/terraform-provider-scaleway/scaleway    576.847s

to improve the usability in case the IP does not exist - see #1
@nicolai86 nicolai86 force-pushed the c/ip-attachment-by-id branch from bb6cc5a to aec42ce Compare July 19, 2017 21:42
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nicolai86
Copy link
Contributor Author

🎉thank you @grubernaut

@nicolai86 nicolai86 merged commit 4f172ab into master Jul 20, 2017
@nicolai86 nicolai86 deleted the c/ip-attachment-by-id branch July 20, 2017 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants