Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(volume_attachment): fix volume_attachment deletion #13

Merged
merged 1 commit into from
Jul 3, 2017
Merged

fix(volume_attachment): fix volume_attachment deletion #13

merged 1 commit into from
Jul 3, 2017

Conversation

nicolai86
Copy link
Contributor

@nicolai86 nicolai86 commented Jun 30, 2017 •
edited
Loading

4a153c4 introduced a deadlock caused my
duplicated calls to mu.Lock() in a function as well as inside a
resource.Retry closure.

fixes #3

--- PASS: TestAccScalewayVolumeAttachment_Basic (452.97s)
PASS

@nicolai86
fix(volume_attachment): fix volume_attachment deletion
74db5ed 
4a153c4 introduced a deadlock caused my
duplicated calls to `mu.Lock()` in a function as well as inside a
`resource.Retry` closure.

fixes #3
@nicolai86 nicolai86 added the bug label Jun 30, 2017
grubernaut
grubernaut approved these changes Jul 3, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix!

@grubernaut grubernaut merged commit 4d9449e into master Jul 3, 2017
@grubernaut grubernaut deleted the b/volume-attachment branch July 3, 2017 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[scaleway provider] scaleway_volume_attachment does not get destroyed and thus can't migrate from C2S to C2M
2 participants
@nicolai86 @grubernaut