-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update terraform SDK to 0.12.0 #127
feat: update terraform SDK to 0.12.0 #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks for this, @QuentinBrosse ! |
The |
Of course! |
I suggest you this command to see the diff without all the vendors: git diff master -- . ':!vendor' |
1e612b6
to
9eacced
Compare
Thanks for the hard work in this! I’ll take another look today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR updates the terraform SDK to make this provider compatible with the new
terraform v0.12.0
. This upgrade doesn't introduce breaking changes.Fix https://github.com/terraform-providers/terraform-provider-scaleway/issues/124
Upgrading to Terraform v0.12
Please, check out the complete terraform guide here.
Steps to check this PR
terraform 0.12.0
$> terraform --version Terraform v0.12.0
plugin-dir
:make test