Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update terraform SDK to 0.12.0 #127

Conversation

QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented May 21, 2019

This PR updates the terraform SDK to make this provider compatible with the new terraform v0.12.0. This upgrade doesn't introduce breaking changes.

Fix https://github.com/terraform-providers/terraform-provider-scaleway/issues/124

Upgrading to Terraform v0.12

For most users, upgrading configuration should be completely automatic. Some simple configurations will require no changes at all, and most other configurations can be prepared by running the automatic upgrade tool. Please read on for more information and recommendations on the upgrade process.

Please, check out the complete terraform guide here.

Steps to check this PR

  1. Download terraform 0.12.0
$> terraform --version

Terraform v0.12.0
  1. Set terraform version in the config file:
terraform {
  required_version = "~> 0.12"
}
  1. Build provider:
make build
  1. Init terraform with a custom plugin-dir:
./terraform init -plugin-dir=$HOME/go/bin

# Output

Initializing the backend...

Initializing provider plugins...

Terraform has been successfully initialized!
[...]
  1. Run tests
make test
  1. Run acceptance tests WARN: This operation cost money
make testacc

@ghost ghost added size/XL and removed size/XL labels May 21, 2019
@QuentinBrosse QuentinBrosse modified the milestone: v1.10.0 May 21, 2019
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolai86
Copy link
Contributor

thanks for this, @QuentinBrosse !

@QuentinBrosse
Copy link
Contributor Author

The v0.12.0 just came out (11h hours ago when I write this comment). I propose to update this PR, is it ok for you @nicolai86?

@nicolai86
Copy link
Contributor

Of course!

@QuentinBrosse QuentinBrosse changed the title feat: update terraform SDK to 0.12.0-rc1 feat: update terraform SDK to 0.12.0 May 25, 2019
@QuentinBrosse
Copy link
Contributor Author

QuentinBrosse commented May 25, 2019

I suggest you this command to see the diff without all the vendors:

git diff master -- . ':!vendor'

@QuentinBrosse QuentinBrosse requested a review from nicolai86 May 25, 2019 16:59
@QuentinBrosse QuentinBrosse force-pushed the qbrosse/update-terraform-sdk-0.12-rc1 branch from 1e612b6 to 9eacced Compare May 25, 2019 17:38
@nicolai86
Copy link
Contributor

Thanks for the hard work in this! I’ll take another look today!

Copy link
Contributor

@nicolai86 nicolai86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuentinBrosse QuentinBrosse merged commit f74e1f9 into scaleway:master May 27, 2019
@QuentinBrosse QuentinBrosse deleted the qbrosse/update-terraform-sdk-0.12-rc1 branch May 29, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform 0.12
3 participants