Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for sbt 0.13, scala 2.10 #542

Closed
raboof opened this issue Jan 31, 2019 · 3 comments
Closed

Drop support for sbt 0.13, scala 2.10 #542

raboof opened this issue Jan 31, 2019 · 3 comments

Comments

@raboof
Copy link
Contributor

raboof commented Jan 31, 2019

sbt 0.13 and scala 2.10 are EOL, and it is slowly getting harder to keep supporting them (for example, fastparse2 is not released for scala 2.10, #510).

What would be a good moment to stop supporting those in future scalapb releases?

@dwijnand
Copy link

dwijnand commented Feb 1, 2019

Just a general reminder that dropping support in newer versions of ScalaPB (or anything) doesn't mean it's impossible to use ScalaPB with sbt 0.13 at all. It just means you have to stick to the already existing versions (and must upgrade for new features and non-backported bug fixes). I mention it because often existing versions are good enough for users still on older versions of sbt.

@thesamet
Copy link
Contributor

thesamet commented Feb 3, 2019

Only scalapb-runtime depends on fastparse, but not our compiler plugin. This means that we can drop Scala 2.10 support while keeping sbt 0.13 supported a little bit longer if necessary.

@thesamet
Copy link
Contributor

We dropped support for Scala 2.10 for our runtime. The compiler plugin has no external dependencies can still be easily compiled with 2.10, so we can still support sbt 0.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants