Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt-scalafix: support execution against files built with Scala 2.12.19 or 2.13.13 #1936

Closed
SethTisue opened this issue Feb 21, 2024 · 11 comments

Comments

@SethTisue
Copy link
Contributor

...which is now on Maven Central, as per https://contributors.scala-lang.org/t/scala-2-12-19-release-planning/6216/13

@bjaglin
Copy link
Collaborator

bjaglin commented Feb 21, 2024

Pending scalameta/scalameta#3573 for semanticdb-scalac support.

A new scalafix release testing full compatibility will follow shortly (using, as well as supporting 2.13.13 also).

Note however that one could most likely use an existing sbt-scalafix release:

@SethTisue
Copy link
Contributor Author

transparently if semanticdb-scalac is backpublished for 4.8.10

perhaps that's actually the plan? you could ask on scalameta/scalameta#3573

I'm publishing 2.13.13 to Maven Central right now

@SethTisue
Copy link
Contributor Author

broadened to include 2.13.13, which is now on Maven Central, as per https://contributors.scala-lang.org/t/scala-2-13-13-release-planning/6315/17?u=sethtisue

@SethTisue SethTisue changed the title Please publish for Scala 2.12.19 Please publish for Scala 2.12.19 and 2.13.13 Feb 21, 2024
@tgodzik
Copy link
Contributor

tgodzik commented Feb 22, 2024

I backpublished Scala 2.12.19 for 4.8.10, 4.8.15 and 4.9.0. Let me know, if anything more is needed!

@SethTisue
Copy link
Contributor Author

not as far as I'm concerned! thanks

@SethTisue SethTisue reopened this Feb 22, 2024
@SethTisue
Copy link
Contributor Author

Oh, oops, what about 2.13.13...?

@tgodzik
Copy link
Contributor

tgodzik commented Feb 22, 2024

That's ongoing 😅 Seems that Scala 2.13.13 surfaced some warnings, so we haven't yet merged it. Will finish everything until tomorrow.

@tgodzik
Copy link
Contributor

tgodzik commented Feb 23, 2024

Done with Scala 2.13.13 for 4.7.8, 4.8.10, 4.8.15 and 4.9.0.

@bjaglin
Copy link
Collaborator

bjaglin commented Feb 24, 2024

Thanks @tgodzik!

Impact of back-publishing validated through scalacenter/sbt-scalafix#389 & scalacenter/sbt-scalafix#390 👍

@xuwei-k
Copy link
Contributor

xuwei-k commented Feb 28, 2024

@bjaglin
Copy link
Collaborator

bjaglin commented Feb 28, 2024

scalafix-testkit for Scala 2.13.13 and 2.12.19 does not available 😢

That's right, sorry for the confusion as this focused on supporting target files compiled with 2.12.19 & 2.13.13. I will update the title to be clearer.

The ability for rule authors build against these patches versions was merged in #1932, but because there is no backpublishing mechanism in Scalafix, it will only have effect in the upcoming Scalafix release (0.12.0), which is blocked by the release Scalameta 4.9.1 for a different reason (4.9.0 had a regression, which I identified by running a sanity check against your rules actually). This should be only a few days away.

@bjaglin bjaglin changed the title Please publish for Scala 2.12.19 and 2.13.13 sbt-scalafix: support execution against files built with Scala 2.12.19 and 2.13.13 Feb 28, 2024
@bjaglin bjaglin changed the title sbt-scalafix: support execution against files built with Scala 2.12.19 and 2.13.13 sbt-scalafix: support execution against files built with Scala 2.12.19 or 2.13.13 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants