From f0797476a7931374177c5047d2fece384d6dd8aa Mon Sep 17 00:00:00 2001 From: Philipp Otto Date: Wed, 31 Jan 2024 15:09:41 +0100 Subject: [PATCH 1/2] fix incorrect logic when deciding whether to use segment stats for adhoc meshing --- frontend/javascripts/oxalis/model/sagas/mesh_saga.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/javascripts/oxalis/model/sagas/mesh_saga.ts b/frontend/javascripts/oxalis/model/sagas/mesh_saga.ts index 24e7900d2fc..3c8b5c4e3a2 100644 --- a/frontend/javascripts/oxalis/model/sagas/mesh_saga.ts +++ b/frontend/javascripts/oxalis/model/sagas/mesh_saga.ts @@ -352,7 +352,7 @@ function* loadFullAdHocMesh( volumeTracing?.hasSegmentIndex && !volumeTracing.mappingIsEditable && visibleSegmentationLayer?.tracingId != null && - additionalCoordinates == null; // TODO remove in https://github.com/scalableminds/webknossos/pull/7411 + (additionalCoordinates == null || additionalCoordinates.length === 0); // TODO remove in https://github.com/scalableminds/webknossos/pull/7411 let positionsToRequest = usePositionsFromSegmentStats ? yield* getChunkPositionsFromSegmentStats( tracingStoreHost, From 2fe95c3c6118b9a8be7b58c15b29d84d2f3a01b2 Mon Sep 17 00:00:00 2001 From: Philipp Otto Date: Wed, 31 Jan 2024 15:11:52 +0100 Subject: [PATCH 2/2] update changelog --- CHANGELOG.unreleased.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md index b7eab164717..b46b2c34f23 100644 --- a/CHANGELOG.unreleased.md +++ b/CHANGELOG.unreleased.md @@ -19,6 +19,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released - Fixed rare SIGBUS crashes of the datastore module that were caused by memory mapping on unstable file systems. [#7528](https://github.com/scalableminds/webknossos/pull/7528) - Fixed loading local datasets for organizations that have spaces in their names. [#7593](https://github.com/scalableminds/webknossos/pull/7593) - Fixed a bug where proofreading annotations would stay black until the next server restart due to expired but cached tokens. [#7598](https://github.com/scalableminds/webknossos/pull/7598) +- Fixed a bug where ad-hoc meshing didn't make use of a segment index, even when it existed. [#7600](https://github.com/scalableminds/webknossos/pull/7600) ### Removed