Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log all data loading errors #8081

Closed
fm3 opened this issue Sep 17, 2024 · 1 comment · Fixed by #8202
Closed

log all data loading errors #8081

fm3 opened this issue Sep 17, 2024 · 1 comment · Fixed by #8202

Comments

@fm3
Copy link
Member

fm3 commented Sep 17, 2024

Bucket requests always return 200, if something went wrong during loading, the array is all-black and the MISSING-BUCKETS header is set. However, no error information is contained.

There is already good error logging in BinaryDataService.handleBucketRequest for everything that happens inside of BucketProvider.load.

However, if the errors occur after that, e.g. while applying the agglomerate mapping, nothing is shown. This error logging should be moved to handleDataRequests or another type of error logging should be created at that level there. Maybe include the errors in the response headers? (Or is that too verbose/can sensitive information be leaked?)

@frcroth
Copy link
Member

frcroth commented Nov 13, 2024

Log errors in "convertIfNecessary" (might need to give request as argument for more info in log). Use rate limiting with datasetErrorLoggingService? -> Code dup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants