Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume Annotation Download: keep all-zero chunks to support merging with fallback layer #7532

Closed
fm3 opened this issue Jan 9, 2024 · 0 comments · Fixed by #7576
Closed

Comments

@fm3
Copy link
Member

fm3 commented Jan 9, 2024

Volume annotation downloads currently skip all-zero chunks. For annotations with fallback segmentations layers, this means the information whether a chunk was drawn over using all black, or whether it is untouched, is lost.

Original report: scalableminds/webknossos-libs#974

I think just removing the !isAllZero(data) in Zarr3BucketStreamSink and WKWBucketStreamSink might not be enough, I have vague memories of a separate mechanism to indicate all-overwritten buckets, possibly also something with version restores. We should look into this in more detail.

Consider only including all-zero chunks in case of a fallback layer being present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant