-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Resolution to Mag (in UI and code where possible) #7378
Comments
@normanrz @hotzenklotz this is your chance to veto this if you think the term Mag is too obscure ;) (Though i think at the terminology meeting that resulted in this document https://docs.webknossos.org/webknossos/terminology.html we also agreed on Mag) |
I think it is more important to be consistent. So, yes for Mag. |
I feel like more strategic tooltips might be tricky in some places of the UI.
|
Sounds good! |
Should I also replace the occurences of the term "resolution" in the backend? |
Backend is a bit tricky, since some of the names of class members are automatically serialized to and from json, which may break backwards compatibility. I can do the backend part (leaving out the spots where compatibility would break) and add it to your PR if that’s ok for you. |
done via #8168 😃 |
Nice! Anything missing for this issue, then? Is the shader stuff still open? Otherwise, feel free to close this :) |
no, vars in the shader code were also renamed 😊 |
Detailed Description
In code and UI, we should switch to the term Mag everywhere for consistency reason. Quoting @fm3, there should be strategic tooltips which explain the concept.
Context
https://scm.slack.com/archives/C5AKLAV0B/p1695737597207699
The text was updated successfully, but these errors were encountered: