Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neuroglancer Precomputed voxel_offset is not respected for sharded datasets #7006

Closed
fm3 opened this issue Apr 24, 2023 · 1 comment · Fixed by #7019
Closed

Neuroglancer Precomputed voxel_offset is not respected for sharded datasets #7006

fm3 opened this issue Apr 24, 2023 · 1 comment · Fixed by #7019
Assignees

Comments

@fm3
Copy link
Member

fm3 commented Apr 24, 2023

When loading Neuroglancer Precomputed datasets, the header can have a voxel_offset, compare https://github.com/google/neuroglancer/blob/master/src/neuroglancer/datasource/precomputed/volume.md#info-json-file-specification

webknossos reads this voxel_offset, and holds it as lazy val voxelOffset: Array[Int], but it is not used when loarding sharded datasets. Should be used when loading data etc.

One approach might also be to use the new transformations feature, compare #6748 (not sure if it is the easiest way, though)

@frcroth
Copy link
Member

frcroth commented Apr 24, 2023

It is already used in chunkIndexToNDimensionalBoundingBox, but that method is not used in the sharded case

@fm3 fm3 changed the title Neuroglancer Precomputed voxel_offset is not respected Neuroglancer Precomputed voxel_offset is not respected for sharded datasets Apr 25, 2023
@fm3 fm3 closed this as completed in #7019 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants