Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show proper error for unsupported mappings (8-Bit and 16-Bit) #3636

Closed
georgwiese opened this issue Jan 16, 2019 · 3 comments · Fixed by #3953
Closed

Show proper error for unsupported mappings (8-Bit and 16-Bit) #3636

georgwiese opened this issue Jan 16, 2019 · 3 comments · Fixed by #3953

Comments

@georgwiese
Copy link
Contributor

When activating a mapping on a 16-bit segmentation, it is correctly applied in the "segmentation" tab, but not in the viewports:

screenshot 2019-01-16 at 16 49 44

Here you can see how the two segments at current position and mouse position are both mapped to ID 1, but they are rendered in different colors.

I wasn't able to repreduce this on a 32-Bit segmentation.

@georgwiese georgwiese added the bug label Jan 16, 2019
@philippotto
Copy link
Member

See #2738 ;) Is this important for your workflow, @georgwiese?

@georgwiese
Copy link
Contributor Author

Ah, I see :)

Actually, it's not important, because we can just use 32-Bit segmentations. That makes sense for us anyway because 216 isn't a lot. For my purpose, it would be fine if WK didn't support it, but it shouldn't fail silently.

@philippotto
Copy link
Member

Ok, cool, then I'll change this issue to cover proper error reporting and leave the other issue at low-pri.

@philippotto philippotto changed the title Mappings are not rendered for 16-Bit segmentation Show proper error for unsupported mappings (8-Bit and 16-Bit) Jan 17, 2019
@philippotto philippotto removed the bug label Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants