Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finer control over who can see Annotations #3350

Closed
fm3 opened this issue Oct 11, 2018 · 1 comment · Fixed by #4315
Closed

Add finer control over who can see Annotations #3350

fm3 opened this issue Oct 11, 2018 · 1 comment · Fixed by #4315

Comments

@fm3
Copy link
Member

fm3 commented Oct 11, 2018

add third option “private” for annotation sharing:

private (only me and my team-managers/admins)
non-public (everyone in my organization)
public (everyone, no need to log in)

(those names are of course preliminary)

this probably means replacing the isPublic flag with an Enum.

this is also the first test of how we can provide a backwards compatible api (assuming #3385 is merged first)

related: https://discuss.webknossos.org/t/cant-share-my-volume-tracing/1159/8 and corresponding issue #3347 with PR #3348

@jstriebel
Copy link
Contributor

jstriebel commented Oct 30, 2018

Possible Steps in the Backend:

  • adapt schema (& add evolution)
  • adapt code to generated (case?) classes
  • adapt routes that set & read this (add as v2 in webknossos.versioned.routes)
  • adapt permissions queries
  • document new route versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants