Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly deal with sparse resolutions #3332

Closed
philippotto opened this issue Oct 8, 2018 · 1 comment · Fixed by #3406
Closed

Correctly deal with sparse resolutions #3332

philippotto opened this issue Oct 8, 2018 · 1 comment · Fixed by #3406
Assignees
Labels

Comments

@philippotto
Copy link
Member

For example, a dataset which has the following resolutions [[4, 4, 2]] should be handled correctly. I'd defer this until this is requested by users, though.

@philippotto
Copy link
Member Author

Today, we got two requests for that so we should think more about it.

A very quick "solution" would be to extrapolate the resolutions array so that [[4, 4 ,2], [16, 16, 16]] is padded to [[1, 1, 1], [2, 2, 1], [4, 4, 2], [8, 8, 4], [16, 16, 16]] or similar.

A more elegant way would probably be to change the rendering code to always do resolution lookups based on exponents instead of indices (so, zoomstep 2 would be mapped to index 0 for a [[4, 4 ,2], [16, 16, 16]]-dataset). However, here we would lose the ability to convert positions into arbitrary zoomsteps (which is quite handy for computations).

@philippotto philippotto self-assigned this Oct 25, 2018
@philippotto philippotto changed the title Correctly deal with weird resolutions Correctly deal with sparse resolutions Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant