Check Team and Project Name Validity in Frontend

[fm3]

for example team names and emails have regex checks in the db schema. it would be useful to ensure this is all also checked in the frontend

Log Time

[hotzenklotz]

Which schema properties are you referring to? The frontend already validates emails, the length of certain fields etc.

[fm3]

right, I did not go through the list, turns out to be very small. I noticed this for team names ( https://github.com/scalableminds/webknossos/blob/master/tools/postgres/schema.sql#L174 )

[philippotto]

https://github.com/scalableminds/webknossos/blob/master/tools/postgres/schema.sql#L174

[philippotto]

The same issue exists for project names (e.g., must not contain spaces). I changed the scope of the issue. So please tackle that, too, @MichaelBuessemeyer :)

[MichaelBuessemeyer]

@philippotto Actually this is already handled in the project-create-view (

webknossos/app/assets/javascripts/admin/project/project_create_view.js

Line 103 in ea0856f

{ min: 3 },

).
I could not find any other possibility to change the name a project.

[philippotto]

The referenced code only checks for a minimum length. But it does not ensure that the name doesn't contain spaces, which seems to be a constraint (at least, I cannot create a project when the name contains spaces). However, I'm a bit confused since the mh lab wk instance has projects with spaces in it.

@fm3 Does the backend forbid spaces in names? The regex doesn't look like that, but I'm not sure whether there's some other magic which ensures this constraint: name VARCHAR(256) NOT NULL CHECK (name ~* '^.{3,}$'),

[fm3]

@philippotto @MichaelBuessemeyer Correct, the database has a weaker check, to still allow the legacy names. However, when creating new projects, the name must also pass the stricter check in

webknossos/app/models/project/Project.scala

Line 69 in 5284339

private val validateProjectName = Reads.pattern("^[a-zA-Z0-9_-]*$".r, "project.name.invalidChars")