-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala 3.2.0-RC2 Open Community Build regressions tracker #15647
Comments
The build failures of which has this behavior: CrossVersion.scalaApiVersion("3.1.0") // Some((3,1))
CrossVersion.scalaApiVersion("3.1.3") // Some((3,1))
CrossVersion.scalaApiVersion("3.1.0-RC1") // None
CrossVersion.scalaApiVersion("3.1.3-RC1") // Some((3,1))
CrossVersion.scalaApiVersion("3.2.0") // Some((3,2))
CrossVersion.scalaApiVersion("3.2.0-RC2") // None <---- this is our failing case
CrossVersion.scalaApiVersion("3.2.1-RC2") // Some((3,2)) I'm not sure if this |
Btw, I'm looking into my own project on that list. I don't think it's a regression, even the current |
@armanbilge technically, that is called a weird regression. |
Some of the other build failures are not regressions per se, but expected based on changes from 3.1 to 3.2. Examples:
|
I offer CI evidence that my project is fine on 3.2.0-RC2. I don't know what's magic about CI. Seems to go badly wrong basically everywhere else, not just Scala 3 but Scala 2 as well. |
Here's a reproducer for the import scala.quoted.*
class ProductTypeField(using val quotes: Quotes)(val name: String)
def foo(using Quotes): ProductTypeField = ProductTypeField()("")
However if I understand correctly this is caused by an intentional source breaking change in #14840? |
I cloned it and built and tested locally on 3.2.0-RC2 and it was fine, so 🤷 |
@griggt great hob. The failure in |
@armanbilge I can confirm that the issue with your project is only happening in our testing environment due to a more strict resource policy (limited memory inside the container) though due to reduced -Xss leading to StackOverflowError. It can re reproduced when using the scala-cli script listed at the begging of the issue (without --locally flag). It can be ignored |
I took a look at
|
When it comes to |
Similarly |
Failures observed in @gzoller /scala-reflection are not regressions either. Scala 3.1.3 introduced a bug fix, which prevented access to the protected constructor of case class. Code snippet from this project fails starting at that version and it is correct behavior (however it's not ok that it was introduced in a patch release, next minor would be more suitable):
Adding a public apply method in the companion object or making the primary constructor public would fix the problem. |
Seeing that we're releasing 3.3.0 and many of the build urls now 404, are we ok just to close this @WojciechMazur? |
Each table contains a list of projects that failed to compile with Scala 3.2.0-RC2, but was successfully built with the given previous version.
A summary is based only on final and released candidate versions of Scala 3.
Information about the last Scala version used for the last successful build might not always be correct, due to lack of data (lack of build for that project with given Scala version)
Open community build might have applied
-source:X-migration
flag if it is detected it could possibly fix the build.Summary only contains projects that failed when compiling source or test files of at least 1 sub-project.
All tested projects: 818
Open Community build run: Build #17 - 3.2.0-RC2-all-projects
Notes for issue reproducers:
To reproduce builds locally you can use:
BUILD ID can be found in the BUILD_URL columns (eg.
Open CB #BUILD_ID
)Helpful options for reproducer scripts:
--scalaVersion VERSION
run build with the selected version of Scala (to check if the problem existed in given release)--withUpstream
- build also all upstream dependencies of failing project--locally
- checkout and build the project locally, without this flag it would try to start a minikube cluster to make the reproduction environment exactly the same as in the Open Community Build run (eg. to compile with the same version of the JDK)Projects with last successful builds using Scala 3.1.3 [15]:
erikerlandson/coulombgchudnov/swearwolfh8io/borschtindoorvivants/subatomicmvv/typineohze/akka-guiceohze/couchbase-scalaohze/sd-utilrssh/cps-async-connectshiftleftsecurity/codepropertygraphtabdulradi/happypathtinkoff/phoboszengularity/benjizio/zio-configshiftleftsecurity/codepropertygraphProjects with last successful builds using Scala 3.1.3-RC5 [4]:
disneystreaming/smithy4seikek/binnykevin-lee/extraslosizm/little-sqlProjects with last successful builds using Scala 3.1.3-RC3 [4]:
jcouyang/meowhedgehogqa/scala-hedgehogProjects with last successful builds using Scala 3.1.1 [10]:
caspercommunityio/casper-scala-sdkearogov/ordsetgzoller/scala-reflectionlorandszakacs/sproutnrinaudo/kantan.replnme.REPL_NAME
) removed in #14021scala-tessella/ring-seqzygfryd/scala-zygf-cementProjects with no successful builds data [16]:
2m/yabai-scalaopen trait
+-Xfatal-warnings
armanbilge/saslpreparturopala/gitignorebenhutchison/scalaswingcontribdelimobil/fs2-hbasegiabao/asm-flowjbwheatley/pact4s-Wconf
flagskatrix/minejsonsciss/soundprocessesvirtuslab/pretty-stacktracesisTupleType
renamed in ##13384vladkopanev/cats-sagaThe text was updated successfully, but these errors were encountered: