Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include end marker information in TASTy #12671

Closed
bishabosha opened this issue Jun 1, 2021 · 0 comments
Closed

Include end marker information in TASTy #12671

bishabosha opened this issue Jun 1, 2021 · 0 comments
Labels
area:tasty-format issues relating to TASTy as a portable standard discussion itype:enhancement

Comments

@bishabosha
Copy link
Member

bishabosha commented Jun 1, 2021

Compiler version

3.0.0

Summary

We should think of a way to encode end markers in TASTy, that is preferrably optional.

With #12541 we only need a single boolean to attach to a tree, so it is efficient.
The span of an end marker can then be recomputed from the tree once it is constructed.

options include:

  • custom section (ok if not present)
  • flag (impossible for trees with no symbol, requires TASTy version bump)
  • annotation (awkward for expression trees, requires Scala version bump)
@bishabosha bishabosha added itype:enhancement area:tasty-format issues relating to TASTy as a portable standard labels Jun 1, 2021
@scala scala locked and limited conversation to collaborators Jun 6, 2023
@ckipp01 ckipp01 converted this issue into discussion #17921 Jun 6, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
area:tasty-format issues relating to TASTy as a portable standard discussion itype:enhancement
Projects
None yet
Development

No branches or pull requests

2 participants