Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve view of long signatures #11120

Closed
pikinier20 opened this issue Jan 14, 2021 · 4 comments
Closed

Improve view of long signatures #11120

pikinier20 opened this issue Jan 14, 2021 · 4 comments

Comments

@pikinier20
Copy link
Contributor

This problem is with us since change of members view:
image
As you can see when member has long prefix (e.g. sealed abstract modifier) then it hides to the left.

@dylemma
Copy link
Contributor

dylemma commented May 20, 2021

I also noticed this while I was fiddling with color theme stuff. It seems to me like the simplest solution is to give up on presenting the signatures like a "table" (i.e. trying to make the word def line up with each signature), though maybe there's some opposition do doing so. Another little annoyance is how the keywords hide behind the 🔗 icon. Here's a little preview of some changes I have in my working copy, LMK what you think:
image

A potential alternative is showing those keywords above the main signature, like how you do with annotations in an expanded signature:
image
although I'm not sure I'm a fan of that.

@pikinier20
Copy link
Contributor Author

TBH I like the table appearance because lined up member names makes whole documentation very clear. However, the second option might look very bad with annotations being above modifiers so I'm also not a big fan. I thought about hiding modifiers at first glance and show them after click (clicked signature would look like your first version - without lineup) but I'm not really sure if this information can be hidden (maybe it's useful to somebody).

@bishabosha
Copy link
Member

Screenshot 2021-05-20 at 11 32 05
it looks like for scala 2 the margin is just a lot longer, but they do also skip override flag (implied by Definition Classes entry) and annotations do not show until you expand

@pikinier20
Copy link
Contributor Author

I think it's fixed with #13317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants