Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assume that parser is namespace-unaware #506

Closed
dubinsky opened this issue Apr 2, 2021 · 2 comments · Fixed by #587
Closed

Do not assume that parser is namespace-unaware #506

dubinsky opened this issue Apr 2, 2021 · 2 comments · Fixed by #587

Comments

@dubinsky
Copy link
Contributor

dubinsky commented Apr 2, 2021

scala.xml.parsing.FactoryAdapter assumes that namespace declarations are passed into the startElement() methods as xmlns attributes, and does not override startPrefixMapping() at all.

As a result, Scala XML parsing can not be done using namespace-aware parser, which is needed - for instance - to handle XInclude.

@ashawley
Copy link
Member

ashawley commented Sep 9, 2021

Sounds like a change worth making. It wouldn't break binary compatibility of a public method, so we could include in 2.1.0 release? We wouldn't need to wait until a 3.0 release?

@dubinsky
Copy link
Contributor Author

Sounds like a change worth making. It wouldn't break binary compatibility of a public method, so we could include in 2.1.0 release? We wouldn't need to wait until a 3.0 release?

Probably won't break compatibility. I plan to start on this after the handling of comments and other lexical things is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants