Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SeqSet #22

Open
NthPortal opened this issue Oct 24, 2020 · 5 comments · May be fixed by #35
Open

Add SeqSet #22

NthPortal opened this issue Oct 24, 2020 · 5 comments · May be fixed by #35
Labels
enhancement New feature or request library:collections status:pending This enhancement request lacks consensus on whether or not to include it

Comments

@NthPortal
Copy link
Contributor

Add SeqSet, mirroring SeqMap.
@NthPortal NthPortal added enhancement New feature or request library:collections labels Oct 24, 2020
@NthPortal NthPortal linked a pull request Nov 2, 2020 that will close this issue
Draft
3 tasks
@NthPortal NthPortal added the status:pending This enhancement request lacks consensus on whether or not to include it label Nov 21, 2020
@NthPortal
Copy link
Contributor Author

NthPortal commented Dec 3, 2020 •
edited
Loading

Note: without adding new implementations for the new traits, this depends on #21

@NthPortal
Copy link
Contributor Author

NthPortal commented Dec 3, 2020 •
edited
Loading

thoughts on this change? (👍 in favour, 👎 against)

@julienrf
Copy link
Contributor

julienrf commented Dec 3, 2020

So, we would have LinkedHashSet as a concrete subtype of SeqSet?

@NthPortal
Copy link
Contributor Author

NthPortal commented Dec 3, 2020 •
edited
Loading

yes, although it will take some fiddling to make that actually work in scala-library-next (if it's not final, we might be able to subtype it with a mixin?)

@SethTisue SethTisue mentioned this issue Apr 8, 2021
Closed
@SethTisue SethTisue mentioned this issue Sep 29, 2022
Closed
@SethTisue SethTisue mentioned this issue Nov 29, 2023
Open
@SethTisue
Copy link
Member

We'd want VectorSet as well: #168

@kpbochenek kpbochenek mentioned this issue Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request library:collections status:pending This enhancement request lacks consensus on whether or not to include it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SeqSet and SetFromMap implementations NthPortal/scala-library-next
3 participants
@SethTisue @julienrf @NthPortal