Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BuildFrom.fromSpecificIterable to fromSpecific #195

Closed
szeiger opened this issue Apr 15, 2019 · 3 comments
Closed

Rename BuildFrom.fromSpecificIterable to fromSpecific #195

szeiger opened this issue Apr 15, 2019 · 3 comments

Comments

@szeiger
Copy link
Contributor

szeiger commented Apr 15, 2019 •
edited
Loading

...and use Iterable instead of IterableOnce as the parameter type. The current version is useless for compatibility.
@szeiger
Copy link
Contributor Author

szeiger commented Apr 15, 2019

But BuildFrom is a trait so we cannot just add the correct method without breaking binary compatibility. So much for that...

@szeiger szeiger mentioned this issue Apr 15, 2019
Closed
2 tasks
@szeiger
Copy link
Contributor Author

szeiger commented Apr 16, 2019

Another option would be to keep the broken interface and add an extension method. It doesn't help for implementing BuildFrom but you cannot implement Factory in a cross-compatible version, either.

@szeiger
Copy link
Contributor Author

szeiger commented May 17, 2019

Fixed in #200

@szeiger szeiger closed this as completed May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szeiger