Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a Travis-CI build for validating pull requests #782

Closed
SethTisue opened this issue May 30, 2017 · 6 comments
Closed

add a Travis-CI build for validating pull requests #782

SethTisue opened this issue May 30, 2017 · 6 comments
Assignees

Comments

@SethTisue
Copy link
Member

we have had this over in scala/scala-lang since scala/scala-lang#378 was merged

the latest config in that repo is https://github.com/scala/scala-lang/blob/master/.travis.yml (and could perhaps largely be just copied over to here?)

@SethTisue
Copy link
Member Author

SethTisue commented May 30, 2017

this came up recently at e.g. #771 which I suspect Travis would have caught

@SethTisue
Copy link
Member Author

@travissarles unless you think having two Travises here would be too confusing 😁

@SethTisue SethTisue changed the title add a Travis build for validating pull requests add a Travis-CI build for validating pull requests May 30, 2017
@travissarles
Copy link
Contributor

I think it's a good idea if we're going to keep the repos separate.

@travissarles travissarles self-assigned this May 30, 2017
@SethTisue
Copy link
Member Author

SethTisue commented May 30, 2017

In the long run, I would still like to see the two repos consolidated. But I assume that's still far enough away (though getting closer!) that this is still very much worth doing in the meantime.

@travissarles
Copy link
Contributor

Yes, I had talked about consolidation with @heathermiller but we decided against it for now.

@SethTisue
Copy link
Member Author

doh! I forgot about Drone. we don't need Travis here, we have Drone doing PR validation instead. thanks @hejfelix for pointing this out.

I don't know why it didn't catch the bug in #771, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants