Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postinstall fail on windows #275

Closed
technophile-04 opened this issue Mar 30, 2023 · 6 comments
Closed

Postinstall fail on windows #275

technophile-04 opened this issue Mar 30, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@technophile-04
Copy link
Collaborator

Its seems that there is some problem when resolving the path while creating the generated file.

Sharing below a SS from the TG group facing an issue :
IMG_2385

Its seems its resolving c:\c:\ instead of c:\

@technophile-04 technophile-04 added the bug Something isn't working label Mar 30, 2023
@carletex
Copy link
Member

carletex commented Mar 31, 2023

We should have a proper way to test this. VM on linux/macOS? XD

@ZakGriffith are you still on windows? If so, could you try?


Also, maybe we should just un-gitignore hardhat_contracts.ts? @sverps mentioned at some point.

  • If you connect your GH repo to vercel, and want to interact with a live contract with your dapp....you need to un-gitignore and commit the file

Thoughts?

@sverps
Copy link
Collaborator

sverps commented Mar 31, 2023

Yeah maybe that's better. We'll need to worry a lot less about build pipelines and the postinstall script etc.

When we make changes to the contract for testing stuff, we need to be mindful of not committing that one anayway, might as well keep an extra eye out for changes to hardhat_contracts file from being committed by accident.

@carletex
Copy link
Member

Ok, let's go with it and see how it feels.

#278

@0xPro
Copy link

0xPro commented Apr 1, 2023

i'm on windows and just needed to change this. not sure if it'll affect mac users though
const __dirname = path.dirname(new URL(import.meta.url).pathname).slice(1);

@carletex
Copy link
Member

carletex commented Apr 3, 2023

This issue will be fixed with #278

In any case, we need to have keep this in mind for future scripts :)

@technophile-04
Copy link
Collaborator Author

Closing this in favour of #278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants