Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zeppelin in CI #878

Open
cgewecke opened this issue Apr 3, 2024 · 0 comments
Open

Fix zeppelin in CI #878

cgewecke opened this issue Apr 3, 2024 · 0 comments

Comments

@cgewecke
Copy link
Member

cgewecke commented Apr 3, 2024

Recent changes at zeppelin have resulted in two GovernorTimelock tests failing for weird time-related reasons.

They fail on the current master branch and at v0.8.5 (the version they're using successfully in github actions). Notably, Circle is taking about 50% longer to execute their suite than github is - there may be some async issue in those tests.

Temporarily exiting the E2E test with 0 so we can still use their suite as a sanity check.

1) GovernorTimelockAccess
       using $ERC20VotesTimestampMock
         "before each" hook for "cancels restricted with delay after queue (internal)":
     Uncaught Error: HardhatChaiMatchersAssertionError: Assertion error: receipt should not be null
      at process.<anonymous> (hardhat/async-test-sanity.js:2:9)
      at process.emit (node:events:526:35)
      at process.emit (node_modules/source-map-support/source-map-support.js:516:21)
      at emit (node:internal/process/promises:150:20)
      at processPromiseRejections (node:internal/process/promises:284:27)
      at processTicksAndRejections (node:internal/process/task_queues:96:32)

  2) GovernorTimelockAccess
       using $ERC20VotesTimestampMock
         "before each" hook for "cancels restricted with delay after queue (internal)":
     Error: done() called multiple times in hook <GovernorTimelockAccess using $ERC20VotesTimestampMock "before each" hook for "cancels restricted with delay after queue (internal)"> of file /home/circleci/project/openzeppelin-contracts/test/governance/extensions/GovernorTimelockAccess.test.js
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant