Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only "--temp artifacts" flag seems to have the desired effect #771

Closed
jmendiola222 opened this issue Nov 29, 2022 · 1 comment
Closed

Only "--temp artifacts" flag seems to have the desired effect #771

jmendiola222 opened this issue Nov 29, 2022 · 1 comment

Comments

@jmendiola222
Copy link

jmendiola222 commented Nov 29, 2022

From solidity-coverage doc here:

The temp command line option lets you to specify the name of a disposable folder to stage the compilation artifacts of instrumented contracts in before the tests are run.

But when trying any other folder name rather than "artifacts", it doesn't seem to work (delete it):

hardhat coverage --temp artifacts ----> Creates the folder, runs and then deletes it. ✅

hardhat coverage --temp myartifacts ----> Does not create "myartifacts" folder, but "artifacts" instead, runs and then it does not delete it. ❌

Couldn't fin anything in the doc pointing to this behavior, although some odd behavior around --temp flag is discussed in #573

@cgewecke
Copy link
Member

For a while now, solidity-coverage has delegated management of the artifacts destination to Hardhat itself. The temp flag is a vestige of an earlier way stage in Hardhat's development.

Am going to remove this is v0.9.0 - updating the roadmap in #825 to reflect that and closing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants