Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laika as site generator #92

Closed
vshalts opened this issue Jan 31, 2017 · 5 comments
Closed

Add Laika as site generator #92

vshalts opened this issue Jan 31, 2017 · 5 comments
Milestone

Comments

@vshalts
Copy link
Contributor

vshalts commented Jan 31, 2017

Hi,

there is pure Scala site generation engine - Laika It is quite interesting. I played with it and did my integration with sbt-site in sbt-laika-blog. Now I decided to go other way.

I realized that maybe it will better to merge that extension back to sbt-site, so it can be reused by others. If you are ready to support one more site generator then I can prepare PR for sbt-site (or you can do it your way). Does it make sense? Are you interested in PR for this site generator?

@metasim
Copy link
Member

metasim commented Feb 2, 2017

Hi @vshalts, thanks for offering to contribute your work. I've also played with Laika in the past, and thought it was a nice engine. Is it still being maintained?

As long as the addition has sufficient scripted tests, has sections in the documentation, and doesn't introduce dependencies that conflict with existing ones (and 2.12 versions are available), then it would be a strong candidate for inclusion. Let me know what you think.

@vshalts
Copy link
Contributor Author

vshalts commented Feb 6, 2017

Hi @metasim, I am right now don't have access to internet for few weeks (travel :) Meanwhile as far as I can tell Lakia doing slow progress and not dead. It compiled against the latest scala 2.11.8 and the latest updates were four month ago. I already have one scripted test, but can add more to make it good tested. I can write initial documentation, but somebody will need to review it due I am not English native speaker and my English is no that good as I want it to be.

I am not sure why we need 2.12 for SBT plugin. From what I understand SBT right now use 2.10 internally. So plugin need Laika for 2.10 and that one exist and supported. On the other hand Laika have a lot of dependencies (to support pdf generation, etc). I am not sure this is good idea to enforce those dependencies for everybody when they don't need it. Maybe we can use provided scope and ask users to to explicitly depend on Laika when them need it.

@metasim
Copy link
Member

metasim commented Feb 6, 2017

I can write initial documentation, but somebody will need to review it due I am not English native speaker and my English is no that good as I want it to be.

Not a problem. We can take care of editing.

I am not sure why we need 2.12 for SBT plugin. From what I understand SBT right now use 2.10 internally.

You're right! I wasn't using my brain, and thinking about a different project (non-plugin) where we'd updated it recently to run on 2.12. Sorry about that! :-)

@vshalts
Copy link
Contributor Author

vshalts commented Feb 6, 2017

Ok then, I will do my best (expect some results after a month from now, due I am very busy right now)

@jonas jonas added this to the 1.2.1 milestone Apr 19, 2017
@jonas
Copy link
Member

jonas commented Apr 19, 2017

Fixed by #95

@jonas jonas closed this as completed Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants