Fix cross-Scala suffix conflict warning #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sbt/sbt#6578 Problem ------- The regex currently expects two segments like2.x or 3.x, but Scala 3 uses _3 as the cross suffix, and it's not caught. Solution -------- Change the regex.
eed3si9n
force-pushed
the
wip/conflict_warning
branch
from
2857d2b
to
0aa7d69
Compare
This was referenced Jul 12, 2021
smarter
added a commit
to scala/scala3-example-project
that referenced
this pull request
Jul 24, 2021
In particular because of sbt/librarymanagement#383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sbt/sbt#6578
Problem
The regex currently expects two segments like2.x or 3.x,
but Scala 3 uses _3 as the cross suffix, and it's not caught.
Solution
Change the regex.