Source is internal and has private methods

[larsrh]

The Source type, which is used for watchSources, is "internal" (why?) and only has private methods. When testing that the files included by watchSources are correct, this is very inconvenient.

[olafurpg]

While porting sbt-scalatex to sbt 1.0 I hit on this error

[error] /Users/ollie/dev/Scalatex/scalatexSbtPlugin/src/main/scala/scalatex/SbtPlugin.scala:52:18: No implicit for Append.Values[Seq[sbt.internal.io.Source], Seq[sbt.io.syntax.File]] found,
[error]   so Seq[sbt.io.syntax.File] cannot be appended to Seq[sbt.internal.io.Source]
[error]     watchSources ++= {
[error]                  ^
[error] one error found

I could not find references to watchSources in http://www.scala-sbt.org/1.x/docs/Migrating-from-sbt-013x.html Would it be possible to provide an implicit Append for File to Source to ease cross-building?

[olafurpg]

FWIW, my workaround is to provide an implicit conversion in a PluginCompat object

// src/main/scala-sbt-1.0/scalatex/PluginCompat.scala
package scalatex

import sbt._
import sbt.internal.io.Source
object PluginCompat {
  implicit def fileToInternalSource(file: File): Source =
    new Source(file, AllPassFilter, NothingFilter)
}

[dwijnand]

Let's call this one closed with:

• Provide companion apply for sbt.internal.io.Source #74;
• [1.0.x] Append instance to add File to Seq[Source] sbt#3438; and
• WatchSource = sbt.internal.io.Source sbt#3478

.. no?

[larsrh]

👍