Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Milli code no longer necessary on JDK10 or greater #211

Closed
cunei opened this issue Dec 16, 2018 · 1 comment
Closed

Native Milli code no longer necessary on JDK10 or greater #211

cunei opened this issue Dec 16, 2018 · 1 comment
Assignees
Labels

Comments

@cunei
Copy link

cunei commented Dec 16, 2018

We can probably modify the Milli code to always use the standard Java calls if the property "java.version" says we are running on JDK10 or greater. The original pull request #92, submitted on 2017-12-06, referred to a then-pending JDK issue whose fix was eventually included in JDK10. We can avoid the JNA dispatching overhead if running on a JDK with a fully working get/setLastModifiedTime() call.

@cunei cunei self-assigned this Dec 16, 2018
@eed3si9n eed3si9n added uncategorized Used for Waffle integration backlog and removed uncategorized Used for Waffle integration labels Jan 2, 2019
@eed3si9n
Copy link
Member

Looks like this was fixed in #274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants